Darkempire78 / OpenCalc

A simple and beautiful calculator for Android
GNU General Public License v3.0
740 stars 83 forks source link

Navigation buttons are not visible #98

Closed Tvirin closed 1 year ago

Tvirin commented 1 year ago

Navigation buttons are not visible on the light theme, as you can see in the screenshot

LineageOS 18.1 / Redmi Note 7

929829

Darkempire78 commented 1 year ago

What is the android version of LineageOS 18 ?

Tvirin commented 1 year ago

What is the android version of LineageOS 18 ?

11

Darkempire78 commented 1 year ago

I found nothing to change the color of the nav buttons, does anyone know how to do this?

user8446 commented 1 year ago

I have the same issue on an Android 10 device on the light theme. On the dark theme, it's fine. Is it possible to have a full time dark theme dark navigation bar or is it not possible to split the nav bar from the overall theme?

Screenshot_20221202-111423

alecchangod commented 1 year ago

Screenshot_20221203-080955 Same here in project-xtended xt(android 13)

ac87 commented 1 year ago

android:windowLightNavigationBar

Or more specifically:

Index: app/src/main/res/values/styles.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
--- a/app/src/main/res/values/styles.xml    (revision 7d1798d366db8b490388f8399836a37346f457f2)
+++ b/app/src/main/res/values/styles.xml    (date 1670605370442)
@@ -5,6 +5,7 @@
         <item name="android:windowActionBarOverlay">true</item>
         <item name="android:statusBarColor">@color/light_foreground_color</item>
         <item name="android:windowLightStatusBar" tools:ignore="NewApi">true</item>
+        <item name="android:windowLightNavigationBar" tools:ignore="NewApi">true</item>
         <item name="android:navigationBarColor">@color/light_background_color</item>
         <item name="android:windowBackground">@color/dark_background_color</item>

@@ -33,6 +34,7 @@
         <item name="android:windowActionBarOverlay">true</item>
         <item name="android:statusBarColor">@color/dark_foreground_color</item>
         <item name="android:windowLightStatusBar" tools:ignore="NewApi">false</item>
+        <item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
         <item name="android:navigationBarColor">@color/dark_background_color</item>

         <item name="android:itemBackground">@color/dark_background_color</item>
@@ -59,6 +61,7 @@
         <item name="android:windowActionBarOverlay">true</item>
         <item name="android:statusBarColor">@color/amoled_foreground_color</item>
         <item name="android:windowLightStatusBar" tools:ignore="NewApi">false</item>
+        <item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
         <item name="android:navigationBarColor">@color/amoled_background_color</item>

         <item name="android:itemBackground">@color/dark_background_color</item>
@@ -107,6 +110,7 @@
         <item name="android:statusBarColor" >@color/material_dynamic_secondary90</item>
         <item name="android:navigationBarColor">@color/light_background_color</item>
         <item name="android:windowLightStatusBar" tools:ignore="NewApi">true</item>
+        <item name="android:windowLightNavigationBar" tools:ignore="NewApi">true</item>
     </style>

     <style name="materialYouDark" parent="AppTheme">
@@ -135,6 +139,7 @@
         <item name="android:statusBarColor" >@color/material_dynamic_secondary20</item>
         <item name="android:navigationBarColor">@color/dark_background_color</item>
         <item name="android:windowLightStatusBar" tools:ignore="NewApi">false</item>
+        <item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
     </style>

     <style name="RobotoFontCondensedLight" parent="android:Widget.TextView">

Results in the following on Android 12 at least:

image image

Darkempire78 commented 1 year ago

It seems good, do you want to make a pull request? @ac87

user8446 commented 1 year ago

Thank you @ac87 @Darkempire78