chore: supress warnings on external library headers and actually get rid of the last old-style casts

DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.

https://www.darkflameuniverse.org/

GNU Affero General Public License v3.0

642 stars 172 forks source link

chore: supress warnings on external library headers and actually get rid of the last old-style casts #1502

Closed jadebenn closed 6 months ago

jadebenn commented 6 months ago

adding the 'SYSTEM' keyword to subdirectories is actually a relatively new CMake feature from what I gather, so it might be worthwhile to discuss bumping up the required version in the main CMakeLists.txt as I'm not sure how this would interact with older versions

EmosewaMC commented 6 months ago

What are alternative solutions that do not involve upgrading cmake?

jadebenn commented 6 months ago

I couldn't figure out another way to get the SYSTEM flag consistently applied to the the dependencies. If there's a way to do that, it would avoid the issue.

EmosewaMC commented 6 months ago

please update the readme as well