DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.
https://www.darkflameuniverse.org/
GNU Affero General Public License v3.0
639 stars 172 forks source link

chore: Use string to access SQLite columns #1535

Closed EmosewaMC closed 4 months ago

EmosewaMC commented 5 months ago

Untested right now. Will try to test later. May do some other small improvements near this code, like removing finalizes and some char* -> string -> copy to data stuff, may not. idk atm.

fixes #1531

EmosewaMC commented 5 months ago

I was planning on doing more improvements in a separate PR. this one is mostly just a number->text replacement and ideally any queries to the cdclient are replaced with an ORM table for caching

EmosewaMC commented 5 months ago

tested the following combat in nimbus station with a stromling and nuckal is working and effects by the stromling play lookup works having a pirate hat on and transferring to another zone works (nimbus station ->gnarled forest) set bonuses work (used 6 piece engineer with valiants) buffs work(equipped ninjago chest and pants and reduced damage by 2) projectiles still land and do damage character create still chooses the correct shirts the player chose switch multiple works (tested with valiant summoner weapon chargeup) claiming and placing a model works paradox teleporter in nexus tower has the correct animation time adding the nuckal mission and smashing them gives the quest item and does not when you do not have the mission can use mounts still can dismantle models to bricks in the inventory

EmosewaMC commented 5 months ago

lookup still works

jadebenn commented 4 months ago

well, frick