resolves a possible memory leak in BrickDatabase, adds stability to character save doc as it can now no longer be null (and given the context of when UpdateXml would is called, it cannot be a stale reference either since an entity must exist in order to save and LoadFromXml).
Tested that saving manually via force-save, logout and /crash all saved my position and my removed banana as expected. The doc was always deleted on character destruction and on any updates, so this is just a semantic change (and now we no longer have new'd tinyxml2::documents on the heap)
resolves a possible memory leak in BrickDatabase, adds stability to character save doc as it can now no longer be null (and given the context of when UpdateXml would is called, it cannot be a stale reference either since an entity must exist in order to save and LoadFromXml).
Tested that saving manually via force-save, logout and /crash all saved my position and my removed banana as expected. The doc was always deleted on character destruction and on any updates, so this is just a semantic change (and now we no longer have new'd tinyxml2::documents on the heap)