DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.
https://www.darkflameuniverse.org/
GNU Affero General Public License v3.0
639 stars 172 forks source link

feat: slashcommands for showall, findplayer, get/openhttpmoninfo, and debug world packet #1545

Closed aronwk-aaron closed 4 months ago

aronwk-aaron commented 5 months ago

/showall and /findplayer use custom packets and are live accurate /who variations

/gethttpmoninfo and /openhttpmoninfo are planned to be used later, just putting in info since it's been RE-d and don't want it lost

Additionally add debug worldPacket for future dev use

Tested all new commands and variation of command arguments

aronwk-aaron commented 5 months ago

image There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

EmosewaMC commented 4 months ago

also remember reference (for structures larger than 8 bytes) in function arguments when possible if a copy is not necessary :)

EmosewaMC commented 4 months ago

image There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

will look into this

EmosewaMC commented 4 months ago

image There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

will look into this

Confirmed to be a bug in the client. This bug is not solvable without client mods. Please utilize another method from the server to communicate the same information from the server.

aronwk-aaron commented 4 months ago

Please utilize another method from the server to communicate the same information from the server.

Will just use this packet with the bug, since there is other functionality that does work in the handle for that packet (such as opening the webpage for /openhttpmoninfo) From the discussion in discord, this is a bug in the client. but other than the undefined behavior quirkiness which causes the chat messages to display incorrectly, it's not a big issue?

EmosewaMC commented 4 months ago

Please utilize another method from the server to communicate the same information from the server.

Will just use this packet with the bug, since there is other functionality that does work in the handle for that packet (such as opening the webpage for /openhttpmoninfo) From the discussion in discord, this is a bug in the client. but other than the undefined behavior quirkiness which causes the chat messages to display incorrectly, it's not a big issue?

Http monitor isn't even implemented, so this is introducing a new bug for zero benefit. If you implement the http monitor then you can use the packet, aside from that there's no point. There are probably other ways to get the shell window open anyways that don't involve that gm.

aronwk-aaron commented 4 months ago

when ahead and removed the commands for now, will add them back with a workaround for this bug once we actually have the http endpoint

EmosewaMC commented 4 months ago

dont forget, there is a way to do exactly the behavior of the httpmon work on the server only to fix the client bug.

aronwk-aaron commented 4 months ago

yeet, got it written down