search

DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.
https://www.darkflameuniverse.org/
GNU Affero General Public License v3.0
639 stars 172 forks source link

chore: move the pet minigame table loading logic out of petcomponent #1551

Closed jadebenn closed 4 months ago

jadebenn commented 4 months ago

Cleaning up the pet component as part of the pet fixes branch. This should be in CDClient with the others.

EmosewaMC commented 4 months ago

windows returns a wstring here instead of a string

aside from this, just make sure to test the changed code path and its lgtm

jadebenn commented 4 months ago

tested in game by intentionally whiffing the pet taming minigame and then succeeding in it. looks like everything works properly, pending the CI

EmosewaMC commented 4 months ago

tested in game by intentionally whiffing the pet taming minigame and then succeeding in it. looks like everything works properly, pending the CI

please also test with missing lxfml files (to ensure that if they are missing the server doesn't crash)

jadebenn commented 4 months ago

please also test with missing lxfml files (to ensure that if they are missing the server doesn't crash)

will do tomorrow

jadebenn commented 4 months ago

Tested that a missing model does not crash the server. Should be good to go once y'all re-approve.