search

DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.
https://www.darkflameuniverse.org/
GNU Affero General Public License v3.0
629 stars 171 forks source link

feat: Command Sorting #1580

Closed TAHuntling closed 2 months ago

TAHuntling commented 2 months ago

feat: Command Organization

Description: Changed CommandInfos to be a map rather than a vector, which allows for easy alphabetization of the different commands available when running /help.

Motivation and Context: Found it hard to sort through the list of commands as it was, so this should be helpful for users to find the commands they are looking for.

How Has This Been Tested?: Running my server and using the help command, for it to show the resulting command list in alphabetical order

EmosewaMC commented 2 months ago

The files are still not formatted to our standard. Please format them

EmosewaMC commented 2 months ago

All feedback from the other pr aside from the lambda to function still must be addressed

TAHuntling commented 2 months ago

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

EmosewaMC commented 2 months ago

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

TAHuntling commented 2 months ago

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

how abour now

EmosewaMC commented 2 months ago

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

how abour now

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

TAHuntling commented 2 months ago

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

Ok I set up the tab stops setting and tried it, did it work?

EmosewaMC commented 2 months ago

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

Ok I set up the tab stops setting and tried it, did it work?

you didnt push your changes

TAHuntling commented 2 months ago

Pending CI. Please also post the tests you did on the last commit with changes to this branch

https://youtu.be/vzjk0NxxUus