DarkflameUniverse / DarkflameServer

The main repository for the Darkflame Universe Server Emulator project.
https://www.darkflameuniverse.org/
GNU Affero General Public License v3.0
629 stars 171 forks source link

fix: mail crash from underflow and document variables #1582

Closed EmosewaMC closed 2 months ago

EmosewaMC commented 2 months ago

fixes an issue where, if a mail of a long enough subject/description/sender would serialize mail to the client, it would crash from trying to write an absurdly large packet.

Tested that mail no longer crashes with string fields that are too long and that mail is still correctly serialized to the client and multiple mails still showed up with their items. Documented fields that were undocumented and removed extraneous functions