BUG: Pet Bouncer incomplete implementation

BrieFlory commented 2 years ago

Make sure you've done the following:

[X] I have checked that this issue has not already been reported.
[X] I have validated that this issue is not a syntax error of either MySQL or SQLite.
[X] I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

427c4a8c33fdb8eca06abd49477e70816f00530b

Issue Description

Pet Bouncers have a variety of inconsistencies with Live that make them feel significantly jankier to interact with.

The current implementation is simple. If a pet is active and you step on the bouncer, the pet will automatically make its way over to the switch and activate it. This behavior is incorrect.

In Live, the pet would make its way to the switch. Then, the player would have the choice of either pressing SHIFT or selecting "Jump" in the Pet Menu to activate the bouncer. Doing so would cost a flat 2 imagination, playing a pet jump animation that syncs up with bouncer activation.

In addition, there are several tutorial popups that don't currently activate the first time around.

On first approach:

On first use:

After first use:

Reproduction Steps

Take out your pet
Approach pet bouncer
Note existing behavior

Expected Behavior

This proper bouncer behavior can be seen in videos from Live:

Lego Universe (Part 23) @ 6:04 (Pet Cove) https://youtu.be/JHqlfK-NaMA?t=364

Lego Universe (Part 52) @ 7:00 (AG Triceratops https://youtu.be/-9NHizE5jZM?t=420

Lego Universe (Part 53) @ 3:00 (AG Monument) https://youtu.be/uBlemmgjPEE?t=180

Environment

Windows client, Linux server

EmosewaMC commented 1 year ago

Related table PetAbilities

jadebenn commented 9 months ago

Worth noting that a full implementation of pet behavior might obviate the need for the mission check implemented in PR #1287, as the client is most likely already blocking 'shift' button presses prior to mission completion

DarkflameUniverse / DarkflameServer