search

Darkhax-Minecraft / Bookshelf

A library mod which adds additional code support beyond what is provided by Forge.
GNU Lesser General Public License v2.1
142 stars 39 forks source link

Backport of injectTable to 1.14.4 #140

Closed puggan closed 4 years ago

puggan commented 4 years ago

A request in Coins, to back-port it to 1.14.4, is not posible without also backporting the Bookshelf injectTable() to 1.14.4. https://github.com/Darkhax-Minecraft/Coins/issues/2

Darkhax commented 4 years ago

I've been considering the deprecation of this method in 1.15.2 so I am not sure if back porting to 1.14.4 is a good idea. I use this method in coins to merge the coin items into the various vanilla loot tables. It's a nice feature for making the mod feel like a bigger part of the world however I don't think it's a core/essential feature and could be backported without this?

Darkhax commented 4 years ago

Didn't mean to close the issue. I am open to back porting this feature if it is considered essential.

Darkhax commented 4 years ago

Since we decided not to backport this I will close again.