search

Darkhax-Minecraft / Bookshelf

A library mod which adds additional code support beyond what is provided by Forge.
GNU Lesser General Public License v2.1
142 stars 39 forks source link

On click NPE with 1.16.4(MC)/35.1.5(Forge)/1.16.4-9.2.14(Bookshelf) #154

Closed Letoric closed 3 years ago

Letoric commented 3 years ago

[10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.darkhax.bookshelf.serialization.BlockIngredientSerializer.read(BlockIngredientSerializer.java:24) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.darkhax.bookshelf.serialization.BlockIngredientSerializer.read(BlockIngredientSerializer.java:11) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.darkhax.bookshelf.Bookshelf.onClick(Bookshelf.java:114) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraftforge.common.ForgeHooks.onRightClickBlock(ForgeHooks.java:789) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:318) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.network.play.ServerPlayNetHandler.func_184337_a(ServerPlayNetHandler.java:958) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:36) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:10) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:733) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:716) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:710) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:695) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.func_240802v(MinecraftServer.java:645) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) [10:13:18] [Server thread/INFO] [STDERR/]: [net.darkhax.bookshelf.Bookshelf:onClick:121]: at java.lang.Thread.run(Unknown Source)

Letoric commented 3 years ago

I'm testing with .15 build now, hopefully it's resolved, and if so sorry for the post without latest version.

Letoric commented 3 years ago

Not seeing it in .15 build, but not 100% what I was clicking on that caused it previously so I'll leave it up to you to close or not.

Darkhax commented 3 years ago

Thanks for resolving, this issue was fixed shortly before you opened this issue. https://github.com/Darkhax-Minecraft/Bookshelf/issues/153