search

Darkhax-Minecraft / Bookshelf

A library mod which adds additional code support beyond what is provided by Forge.
GNU Lesser General Public License v2.1
145 stars 39 forks source link

Add Missing MHF Skulls and Reorder Logically #84

Closed RuiNtD closed 7 years ago

RuiNtD commented 7 years ago

Missing MHF Skulls (Creeper, Skeleton, WSkeleton, and Zombie) were added and the two Present skulls were reordered to be with the Blocks instead of by themselves.

Darkhax commented 7 years ago

This is a very weird request, but thanks x)

RuiNtD commented 7 years ago

So... how come this pull request was denied? And how is this a weird request? I only added the missing MHF heads to SkullUtils and reordered the two present heads based on the list from Marc Watson, the person who made the MHF heads (MHF even stands for Marc;'s Head Format).

Darkhax commented 7 years ago

I am not sure why this PR was closed, I guess I hit the close instead of close and merge. As for why I said this was weird, this is just a feature that I didn't think anyone really cared much about.

Darkhax commented 7 years ago

There doesn't appear to be any merge conflicts, so I would be more than happy to merge this PR if you are still okay with it being added.

RuiNtD commented 7 years ago

The Util still exists and I don't see any reason for it to remain incomplete, so I am still okay with it being added.