search

Darkhax-Minecraft / BotanyPots

Adds some flower pots that can be used to grow various crops.
GNU Lesser General Public License v2.1
92 stars 71 forks source link

Massive lag with IntegratedDynamics/Tunnels #366

Open Wyrrrd opened 5 months ago

Wyrrrd commented 5 months ago

Minecraft Version

1.20.1

Mod Version

13.0.22

Mod Loaders

What environment are you running the mod in?

Dedicated Server

Issue Description

Pumping out a hopper botany pot with an item importer from IntegratedTunnels from below adds massive lag to the server. Just 10 of those were enough to make my average setup unplayable.

As of the issue CyclopsMC/IntegratedTunnels#285, this is caused by BotanyPots using a slot-based item handler interface. This causes the pot to iterate over all slots of the inventory below, which is quite a lot when using a large ID/IT network.

Steps to reproduce the problem:

  1. Put an item importer pointing at the bottom of a hopper botany pot.
  2. Add plant and soil to the pot.
  3. Add a boolean "true" variable card to the importer.
  4. Repeat 1.-3. some more
  5. Connect a big ID/IT network with lots of inventories

Spark profile

Darkhax commented 5 months ago

Thanks for letting me know about this issue. It sounds like this would require hardcoded support for their custom inventory system which which I am not too excited about doing, but I will reach out to them and see what we can do about this.