Darkhax-Minecraft / BotanyPots

Adds some flower pots that can be used to grow various crops.
GNU Lesser General Public License v2.1
102 stars 78 forks source link

[BUG] Water/Lava fluid textures are not correct on pot #409

Closed degiel1982 closed 4 months ago

degiel1982 commented 4 months ago

Minecraft Version

1.20.4

Mod Version

16.0.4

Mod Loader

Fabric

What environment are you running the mod in?

Client

Issue Description

When I add a water/lava bucket as soil the textures are the textures of different items instead of the fluid texture.

I made a new minecraft client with only this mod installled. No shaders and no other mods installed. Modrinth installs automaticly these mods to have your plugin working:

  1. Fabric API
  2. Bookshelf

I added the waterbucket and this is the resulting texture:

image

NOTE : The mod it working and retreives kelp

Darkhax commented 4 months ago

Thank you for reporting this issue, I've confirmed it on Forge as well. This is an issue in the Bookshelf dependency, I should have a fix for it soon.

degiel1982 commented 4 months ago

You are welcome :), Thanks for your response.

Darkhax commented 4 months ago

This issue should be fixed in Bookshelf 23.1.9. The file is being processed on CurseForge and Modrinth and should be available publicly soon.

Fixed by https://github.com/Darkhax-Minecraft/Bookshelf/commit/bfecc97057117e5ebecba94f6f9ed062414df36c