search

Darkhax-Minecraft / BotanyTrees

Allows you to grow trees in small pots.
GNU Lesser General Public License v2.1
6 stars 15 forks source link

Added terraqueous, ars_nouveau, Fruit Tree Support #14

Closed ModernGamingWorld closed 3 years ago

ModernGamingWorld commented 3 years ago

Closes this I think https://github.com/Darkhax-Minecraft/BotanyPots/issues/94

Darkhax commented 3 years ago

Thanks for the PR. When adding non-vanilla support you need to include conditions that prevent the support from loading when the mod is not present. You can find an example of this here. I recommend adding two conditions, the first only loads the file when the mod ID specified has been loaded, the second only loads the file when a specific item is present. The item check is used to prevent errors if the mod decides to remove that item later on.

ModernGamingWorld commented 3 years ago

@Darkhax Fixed

ModernGamingWorld commented 3 years ago

These should be good to close after this pr is sent through to the Mod

https://github.com/Darkhax-Minecraft/BotanyTrees/issues/10 https://github.com/Darkhax-Minecraft/BotanyTrees/issues/13

Darkhax commented 3 years ago

Wow, that's a lot of trees. Thanks!