Darkhax-Minecraft / BotanyTrees

Allows you to grow trees in small pots.
GNU Lesser General Public License v2.1
6 stars 15 forks source link

Support Pixelmon mod Apricorn trees #38

Closed ceschiavolim closed 1 year ago

ceschiavolim commented 1 year ago

Could you add support for Apricorn trees from Pixelmon mod?

If you need I already have json files they just need to be balanced.

Darkhax commented 1 year ago

Hello, yes I would be interested in adding the Pixelmon apricorn trees. If you have the JSON files I would appreciate having them as a basis to work from.

ceschiavolim commented 1 year ago

An example: { "type": "botanypots:crop", "seed": { "item": "pixelmon:blue_apricorn" }, "categories": [ "dirt" ], "growthTicks": 2400, "display": { "block": "pixelmon:apricorn_plant_blue" }, "results": [ { "chance": 0.5, "output": { "item": "pixelmon:apricorn_log_blue" }, "minRolls": 1, "maxRolls": 1 }, { "chance": 0.1, "output": { "item": "minecraft:stick" }, "minRolls": 1, "maxRolls": 2 }, { "chance": 0.2, "output": { "item": "pixelmon:blue_apricorn" }, "minRolls": 1, "maxRolls": 3 }, { "chance": 0.05, "output": { "item": "pixelmon:apricorn_leaves_blue" }, "minRolls": 1, "maxRolls": 2 } ] }

ceschiavolim commented 1 year ago

apricorns.zip

ceschiavolim commented 1 year ago

In the compressed file there are the seven variations.

ceschiavolim commented 1 year ago

I tried to make mints, but it's giving a strange error that I'm not able to identify

{"type":"botanypots:crop","seed":{"item":"pixelmon:mint_seeds"},"categories":["dirt"],"growthTicks":2400,"display":{"block":"pixelmon:mint"},"results":[{"chance":0.01,"output":{"item":"pixelmon:mint_lonely"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_adamant "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_naughty "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_brave"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_bold"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_impish "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_lax "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_relaxed"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_modest "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_mild "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_rash "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_quiet "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_calm "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_gentle "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_careful "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_sassy "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_timid"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_hasty"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_jolly "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_naive "},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_quirky"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_bashful"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_serious"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_docile"},"minRolls":1,"maxRolls":3},{"chance":0.01,"output":{"item":"pixelmon:mint_hardy"},"minRolls":1,"maxRolls":3}]}

I don't know why the option list was so big, since the same plant has a chance to generate all types

ceschiavolim commented 1 year ago

As Berries are now also trees I am sending the Apricorns JSON files. hope this helps

ApricornsAndBerries.zip

Darkhax commented 1 year ago

Thanks for the help, I will look into cleaning these up and having them added soon.

ceschiavolim commented 1 year ago

Thank you very much for your attention and I look forward to it.

Darkhax commented 1 year ago

After looking into things more I felt that the pixelmon stuff would be better as it's own addon as they kind of blur the line between trees and normal crops. You can find that addon here. My version is currently missing logs/leaves/sticks from the drop table which is more in line with how similar edge case plants are handled, and the mint plant is also missing while I figure out the best way to balance it. Currently thinking a 10 or 15 minute growth time and then have a 5% chance for each of the mints to drop. Ideally it would just drop one mint but the system used in this older version is not flexible enough for drops like that.