Darkhax-Minecraft / BotanyTrees

Allows you to grow trees in small pots.
GNU Lesser General Public License v2.1
6 stars 15 forks source link

Correct Twilight Forest saplings to not as exploitable #55

Closed GizmoTheMoonPig closed 1 year ago

GizmoTheMoonPig commented 1 year ago

Hello! I work on the mod Twilight Forest, and I noticed you guys somewhat recently added compat for our trees to this mod. I actually ended up making compat for the mod myself in This Commit, as at the time there wasn't any builtin compat and I didn't know if it was returning. I found out today that you guys DID in fact add compat for TF in the base mod, and I have a few issues with it. The biggest one being that magic saplings can yield their cores. This is a VERY bad thing, as the cores are not supposed to be obtainable in item form, nor are they supposed to be renewable. I also noticed that the magic trees can also drop their saplings, which, again, not a good thing. The tree leaves don't drop saplings as we don't want treasure saplings to be renewable. This PR exists to correct those issues, as well as adds liveroot and more sticks to each tree. Our trees grow some fancy roots so I figured it would be nice to include the drops of those as well. The files overall are more in line with what I made for my compat with the mod. Please let me know if you would like me to port this to the 1.19.2 branch as well, I would be happy to do so. Please also let me know if you have any concerns with what I've done here, and I will correct them as soon as I can. Thank you!

Darkhax commented 1 year ago

Hello, thank you for reaching out about this. I apologize for any issues this may have caused the TF team. I rely pretty heavily on the community to PR support for various mods which unfortunately leads to issues like this from time to time. Feel free to submit your balancing changes for the other versions as well.