Darkhax-Minecraft / Enchantment-Descriptions

Displays descriptions about an enchantment on the tooltip.
100 stars 50 forks source link

Suggestion #159

Closed Cataratas closed 1 year ago

Cataratas commented 1 year ago

When requireKeybindPress is enabled it would make more sense to use stack.isEnchanted() instead of stack.hasTag() in the file EnchDescCommon, line 32. It would avoid cases where an item has a tag but no enchantments.

with stack.hasTag() Captura de tela 2022-10-06 194642

with stack.isEnchanted() Captura de tela 2022-10-06 194504

Darkhax commented 1 year ago

Thanks, this was an unintentional bug. Should be fixed in the next 1.19.2 version.