Darkhax-Minecraft / ItemStages

Allows items to be put into stages.
GNU Lesser General Public License v2.1
7 stars 18 forks source link

[Suggestion] AddItemStageByMod #11

Closed TheLimePixel closed 6 years ago

TheLimePixel commented 6 years ago

It's self-explanatory. I suggest adding a way of restricting all items from a certain mod, if it's possible.

Matryoshika commented 6 years ago

You can do this easily enough with a for-loop using CraftTweaker's loadedMods lookup.

for item in loadedMods["thermalexpansion"].items { mods.ItemStages.addItemStage("electrical", item); }

Yes, it's not a simple one-liner, but it is functionally exactly the same.

Darkhax commented 6 years ago

I have been considering this feature for a while. You can use loops like the one described above to easily stage an entire mod, and this has been the preferred way to do this for many modpack authors because it allows for more optimization. I will add the requested feature either way.

Lanse505 commented 6 years ago

I highly second this x) For loops are fine and all, but yea nope, I'd prefer not having a few million lines of output prints for each base item + meta/nbt variations :P

Darkhax commented 6 years ago

This feature is included in 1.0.28

mods.ItemStages.stageModItems("one", "minecraft");