search

Darkhax-Minecraft / ItemStages

Allows items to be put into stages.
GNU Lesser General Public License v2.1
7 stars 18 forks source link

Broken JEI hiding when restricting items with stageModItems #17

Closed TheLimePixel closed 6 years ago

TheLimePixel commented 6 years ago

Items restricted with stageModItems are restricted (have the tooltip and can't be held), but are still in JEI image

To clarify, Ender IO was just used as an example. It's the same for the 70 other mods' items I have restricted like this.

TheNimbleNinja commented 6 years ago

bump

Darkhax commented 6 years ago

I can not reproduce this issue no matter what I do. Using the latest versions of all my mods, and the line mods.ItemStages.stageModItems("one", "minecraft"); in my script, all vanilla items with two exceptions are staged correctly. The two exceptions here are the water and lava fluid entry, which is fine because this mod does not support fluids yet. And enchanted books which are not the maximum level for their enchantment, which only affects items that only show up in the vanilla search tab, and not any other tab.

If the item is in a creative tab that is not the vanilla search tab, and is not a fluid entry, it should be hidden perfectly fine. Please make sure you're using the latest versions of Forge, Bookshelf, JEI, CraftTweaker, GameStages, and ItemStages. If you still have the issue it is likely another mod that is conflicting with or breaking things.

Darkhax commented 6 years ago

The lookup code has been improved and will now catch all the enchantment books from the edge case I mentioned in my response. Fluids are still not supported at this time. https://github.com/Darkhax-Minecraft/Bookshelf/commit/4aa96f3ef59eeeb29892b1bc372ea0790cf41702