search

Darkhax-Minecraft / ItemStages

Allows items to be put into stages.
GNU Lesser General Public License v2.1
7 stars 18 forks source link

Not everything gets hidden in JEI [1.16] #61

Open Diversion98 opened 3 years ago

Diversion98 commented 3 years ago

Hi,

After restricting almost every mod that adds items behind a stage, some items will still show up in JEI. I took some pictures of it, hope this helps u.

Cheers!

2021-08-22_17 14 36 2021-08-22_17 15 34 2021-08-22_17 18 30 2021-08-22_17 18 33

Darkhax commented 3 years ago

Hello, thanks for the issue report. I can recreate your issue with Chisel and Bits but have not looked into the other mods yet. After debugging things it looks like it may be a bug with JEI or potentially each of those specific mods. I've already reached out to some of the mod authors and will work with them to solve this. The following notes are just to help me and the other devs keep track of things.

  1. Chisel is adding the block_bit variants via addIngredientsAtRuntime.
  2. ItemStages is grabbing all ItemStack being displayed using getAllIngredients(VanillaTypes.ITEM).
  3. Chisel's entries are being added to the list before stages gets the ingredients. log - 39
  4. When stages accesses the ingredient list only one block_bit exists. log - 1286
  5. After stages runs there are no block_bit in the ingredient list, but they still display. log - 2538
Diversion98 commented 2 years ago

Any news on this issue? :)

Darkhax commented 2 years ago

Unfortunately I haven't heard anything back from the JEI team. I will reach out again.

Diversion98 commented 2 years ago

Allright no worries, was just curious :) It's not that big of an issue ;)

HenryMaxler commented 2 years ago

I noticed this issue happen with the mod Modernxl. Additionally, only some of the items are still visible. And, when I remove stages, or do /gamestage clear, those items duplicate in JEI so it shows more and more of them.

Diversion98 commented 2 years ago

my items in JEI don't get duplicated though, just tested it

Rololow commented 4 months ago

image The mod born in chaos doesn't hide too.. im in 1.19.2 with the version 5.1.4. Others items from others mods shows too. In this version, chisels and bits doesn't show anymore. (they doesn't runtime anymore..)

maybe use this https://github.com/mezz/JustEnoughItems/blob/1.20/CommonApi/src/main/java/mezz/jei/api/runtime/IIngredientManager.java#L78 to get runtime ingredients..