search

Darkhax-Minecraft / JourneyMapStages

Allows Journey Map to be gated behind custom modpack progression systems.
GNU Lesser General Public License v2.1
0 stars 7 forks source link

[Bug] IMPORTANT: Spamming the map toggle key reveals the minimap slightly #11

Closed MasterBuilder747 closed 5 years ago

MasterBuilder747 commented 5 years ago

Journeymap has a keybind that can toggle the minimap from appearing on the screen or not.

Apparently by spamming this key, the minimap can be seen for a split second even when the gamestage is enabled.

I find this a flaw with this mod, as it doesn't completely remove the ability not to see the mini map, when the gamestage is set. I feel like this issue had maybe been resolved earlier, but all of a sudden now it seems to have come back.

If it does some sort of tick check, then instead I recommend to perhaps disable to key instead (some kind of jouneymap keybind integration?) so that even when the user presses the key, Journeymap won't fire their event to reveal the minimap.

Also to note this occurs only with Journeymap 5.5.4. Apparently I see another issue that says that there isn't even support for the newest version :p

Darkhax commented 5 years ago

This isn't strictly a bug. We were working with the JourneyMap team to implement support for hiding and restrictions with their API however they pulled it from CurseForge shortly before release. The current iteration of this mod is somewhat of a hack to get around the removed official support. As a result players can still cheese things and get the mod to show. I believe the mod is also client side optional so they can just remove it. (That is by request of the JMap team).

I am hoping that in the future I will be able to release a better version of this mod that makes use of official API features, instead of the current approach.