search

Darkhax-Minecraft / Open-Loader

An open source resource and data loader for Minecraft.
GNU Lesser General Public License v2.1
19 stars 7 forks source link

1.16.5 compatibility about minecraft datapack #29

Closed 2929762171 closed 1 year ago

2929762171 commented 1 year ago

I 'm playing a mod : RingsOfAscension-1.16.4-1.6.0, then I found that I couldn't get any ring from the chest. U@8E(MSQN1N1G29VJZR4@KF I change some animals entities loot tables for more meats, it worked in the OpenLoader, this means that the pack has no errors. but it caused the rings problem, just because the folder named "minecraft". When I remove this minecraft folder, problem can be solved. But I do want to use it in the OpenLoader.

B)HXPOWS @C9I}LN98E6G7K Maybe it's the special way it works that causes this problem. Maybe other mods will have this problem. image

2929762171 commented 1 year ago

Loading sequence caused this problem. Other mods had modified the data packet, but openloader always load at last, when I create a pack of vanilla, it will reset the vanilla data, and destroyed other modules' modification of vanilla.

Darkhax commented 1 year ago

@2929762171 Are you including all of the vanilla datapack files in your custom data pack? This is unnecessary and will cause issues like the one you are having now. You should only include files you have actually modified.

If you have intentionally edited the loot tables of chest loot for example, it is your responsibility to account for any changes mods may make. This is an intentional design choice by the Forge mod loader as they give user datapacks the final say on how loot tables are loaded.

2929762171 commented 1 year ago

I do have plans to edit other parts like chest loot table so I keep all of them, and that is why I want to use openloader to load it, only /reload is needed to test quickly... I think it would be perfect if you could provide a configuration about custom loading order. Thanks for your reply.

Darkhax commented 1 year ago

It is not an issue with loading order. As I have already said Forge treats user defined packs as the definitive value for a loot table and will not allow mods to edit the results. You are explicitly telling Forge to ignore all mod related modifications to the loot table. This is not an issue with this mod or an issue I can fix, the fix is to only replace files you actually want to replace.