search

Darkhax-Minecraft / Simply-Arrows

Adds new arrows. What do you expect.
GNU Lesser General Public License v2.1
2 stars 4 forks source link

Arrow entities are not registered #7

Open NeRdTheNed opened 2 years ago

NeRdTheNed commented 2 years ago

During mod initialisation, Forge usually expects mods to register entities. As a result of the arrow entities not being registered, any shot arrows are not saved when saving and reloading a world. Additionally, attempting to serialise the NBT data of an EntitySimpleArrow by calling serializeNBT() on the entity throws an exception, due to getEntityString() returning null. There are probably some other undesirable side effects I haven't found as well.

Sorry for posting an issue when this mod hasn't been updated in a while, I understand if you aren't supporting it anymore. I could create a pull request if needed, I just might have to update some ForgeGradle related dependancies because I mainly develop on MacOS, and MacOS doesn't tend to cooperate with older versions of ForgeGradle.

Darkhax commented 2 years ago

Thanks for the issue report. I am open to merging a PR to fix this however making the PR would likely require more effort than it's worth. The current build scripts for this project are broken as Gradle, ForgeGradle, and some other plugins require updating and have compatibility issues with older versions of the game. I also moved to a new build server with different environmental variables and pipeline structure that would need to be accounted for. I took a stab at it myself the other night but it looks like FG5 is not applying ATs for JEI and Bookshelf correctly.