search

Darkhax-Minecraft / Thirsty-Bottles

A mod to make water bottles as thirsty as I am.
2 stars 2 forks source link

[BUG] Deletes waterlogged blocks #17

Closed ThatGravyBoat closed 7 months ago

ThatGravyBoat commented 8 months ago

Minecraft Version

1.20.4

Mod Version

10.0.2

Mod Loader

NeoForge

What environment are you running the mod in?

Dedicated Server

Issue Description

When you use a bottle on a water logged block it deletes the block from the world instead of removing the waterlogged state this is because of this line here just setting the block to air: https://github.com/Darkhax-Minecraft/Thirsty-Bottles/blob/1.20.4/common/src/main/java/net/darkhax/thirstybottles/mixin/MixinBottleItem.java#L27

Darkhax commented 7 months ago

Thanks for reporting this issue. Definitely a major oversight on my part lol 😅

Darkhax commented 7 months ago

Fixed in https://github.com/Darkhax-Minecraft/Thirsty-Bottles/commit/dd8298a75464855678004fdf55da43e6a32480fa