search

Darkhax-Minecraft / Tips

Adds tips to loading screens of Minecraft.
GNU Lesser General Public License v2.1
50 stars 47 forks source link

[BUG] This just stopped working #144

Open polykatt opened 4 months ago

polykatt commented 4 months ago

Minecraft Version

1.20.1

Mod Version

12.1.7

Mod Loader

Fabric

What environment are you running the mod in?

Client

Issue Description

I think it might just be because of this latest update because it worked fine before

Darkhax commented 4 months ago

Hello, thanks for reporting this issue. The 12.1.7 update changed a lot of things so it's definitely possible something broke. Could you please explain what you mean when you say it's not working? Like is it crashing or are the tips just not being displayed? I would also appreciate it if you could upload your log file and the config file here so I can check those for more information.

polykatt commented 4 months ago

Yeah, so I noticed that tips are not showing on the world creation screen. But they are there on the pause menu and when logging out of a world.

latest.log

I haven't changed anything in the config file

tips.json

Darkhax commented 4 months ago

Thank you for verifying this issue. I've also been able to verify it and should have a fix out soon.

Darkhax commented 4 months ago

This issue should be fixed in 12.1.8, please try it out and let me know how it goes. The file was just uploaded to CurseForge and Modrinth so it may take a few minutes to show up.

polykatt commented 4 months ago

Yeah so the tips on world creation screen don't cycle. It displays the same one about wandering traders. And on the pause menu and logging out they don't seem to be cycling randomly - they start at the same one about wandering traders then follow the same sequence of tips every time. latest.log

Edit: Actually it seems like its not just starting at the same one tip about wandering traders but it does seem to start at some random tip and then follow the same sequence instead of random cycling. This seems to change every time I relaunch the game. Also they do seem to be cycling on the world creation screen now. I think maybe things are mostly fine now. Not so sure but I guess its okay - maybe with more playtime I'll can see what issues are really sticking.

Darkhax commented 4 months ago

@polykatt Thanks for letting me know. I will take a look at the tip selection logic and see if there's anything wrong.