DarklightGames / DarkestHour

Darkest Hour: Europe '44-'45
https://store.steampowered.com/app/1280/Darkest_Hour_Europe_4445/
67 stars 20 forks source link

Deploy icon can stay stuck on screen after dropping a weapon #665

Closed cmbasnett closed 7 years ago

cmbasnett commented 7 years ago

Reproduction Steps

  1. Get a deployable weapon (machine-gun or anything with a bipod).
  2. Go up to a ledge and get the "deploy" prompt icon on your HUD.
  3. Drop your weapon.
  4. Note that the HUD icon is still there. It won't disappear until you bring up a new weapon.

Analysis

There's a variable called bCanBipodDeploy that is governing whether or not to show this icon. However, this variable is read-only to UnrealScript and is only ever set in native code. There's a bug in the native code where it does not set it's value to false if there is no weapon currently equipped. To fix this, all we need to do is to add in an extra check on this line to make sure that the player currently has a weapon in their hands.

┆Issue is synchronized with this Trello card

cmbasnett commented 7 years ago

Fixed in commit 3228ac9.