search

DarklightGames / DarkestHour

Darkest Hour: Europe '44-'45
https://store.steampowered.com/app/1280/Darkest_Hour_Europe_4445/
69 stars 21 forks source link

Objectives that use clearing logic are broken #667

Closed cmbasnett closed 7 years ago

cmbasnett commented 7 years ago

It seems that some sort of event logic is not properly firing on these objectives. This is obviously a result of the recent (and unwarranted) changes to the objective code. This is live in v7.2.

20170222193414_1 20170222183002_1 20170222192534_1

┆Issue is synchronized with this Trello card

cmbasnett commented 7 years ago

Found at least one of the problems, and the cause is quite obvious just by looking at the code. Very easy to reproduce.

  1. Capture an objective that is set to disable on clear with an enemy still in the cap.
  2. Leave the capture area and let the defending team capture the point back.

At this point, the objective will be disabled, blocking it from being recaptured, thus breaking the map.

cmbasnett commented 7 years ago

Fixed in commit 17c4b550.

AndrewTheel commented 7 years ago

I have fix for this bug, just re-opened so we know it is currently back. It seems there are 2 bugs here though. I fixed the simple one where defender is in cap and captures back the objective at which point the obj deactivates. The other I'm not sure what it even is yet. I think it might have to do with clearing the objective out, but more testing/knowledge is required.

AndrewTheel commented 7 years ago

Possibly fixed in: https://github.com/DarklightGames/DarkestHour/commit/f81d1ffe7734121a774fcdce1cb0010a50c2cafa

Will keep open as I'm not 100% sure "both" issues are fixed.

AndrewTheel commented 7 years ago

It think this was resolved, if it isn't it needs to be reported with reproduction steps.