DarklightGames / io_scene_psk_psa

A Blender extension for importing and exporting Unreal PSK and PSA files
GNU General Public License v3.0
310 stars 20 forks source link

Can't import animations to armatures that are missing bones. #53

Closed CraftPig closed 7 months ago

CraftPig commented 9 months ago

This issue is still present, im unable to import animations to armatures with missing bones, that exist in the anim data. There doesn't seem to be anything in the settings that im missing. Other blender psa/psk importer plugins do not have this issue.

image

mossyblog commented 8 months ago

Same issue.

cmbasnett commented 8 months ago

Can you both send me the PSK and PSA you are using? I only need one pair. This was reported earlier under https://github.com/DarklightGames/io_scene_psk_psa/issues/46, but I couldn't recreate the issue with the files that were given to me.

cmbasnett commented 8 months ago

@CraftPig @mossyblog

Irastris commented 8 months ago

Gonna step in since they have yet to reply. This same issue can be observed with High on Life/High on Knife when trying to import animations belonging to Harper.

Here is the PSK and a selection of 5 PSAs: Harper.zip

cmbasnett commented 8 months ago

@CraftPig @mossyblog @Irastris There seems to be a misunderstanding here. What you're likely experiencing is that you have not actually selected the sequence(s) you want to import from the PSA itself. Simply selecting the file and pressing import will result in no sequences being imported because all the sequences are deselected by default.

image

The addon was initially designed around importing from PSA files with a huge number of animations (hundreds or even thousands), so by default, all sequences are deselected and the user is required to manually select which ones they want.

I will change it so that all the sequences are selected by default since I've had a number of reports that all boil down to users not realizing they have to do another step to get the sequences imported.

cmbasnett commented 8 months ago

Version 5.0.6 (https://github.com/DarklightGames/io_scene_psk_psa/releases/tag/5.0.6) now has the sequences selected by default. Please let me know if this fixes the issues you are having.

Irastris commented 8 months ago

Close, my mistake was elsewhere.

What I failed to realize was that regardless of a warning (which I was mistaken in believing to be an outright error) regarding missing bones, the addon's default behavior is to not actually assign any of the sequences to the selected armature, you instead must go into the Action Editor afterward to do so. Realizing this makes the default setting of giving the imported sequences a fake user make even more sense as well.

If a user does not have an Action Editor panel already open, or an Outliner panel in Blender File/Orphan Data mode, it can be difficult to notice whether or not the animation was actually imported. When there's no immediate feedback visible to the user for the import, other than a popup dialog that's very easy to dismiss before it's readable as a result of the mouse being in motion, it can make it seem like nothing was imported at all

Personally I'm not sure there is any way to "improve" this, I would suggest simply documenting the behavior in the README so that users are aware going in.

Regardless I want to say thank you for your amazing work! Prior to 3 days ago I'd been using another PSK importer for years which I'd shoddily modified in an attempt to streamline the process for modding Unreal Engine games. Your addon by comparison does all of the same things from the get go, and also adds new features I'd not even been aware were available such as FModel's embedded morph targets, I've been manually importing glTFs from the Umodel ACL fork all this time LMAO!

cmbasnett commented 8 months ago

Thank you for the kind words!

And yea, the PSA import operator explicitly doesn't try to alter the scene/dependency graph as it might create undesirable side effects to change the active action on the armature. I have updated the README to note that an additional step is required to apply the actions to the armature.

P.S. I noticed this repository got a dozen new stars in like a day, has your modding community just discovered this addon? If so, what game are you modding?

Irastris commented 8 months ago

Afraid any uptick in traffic you may be getting is a coincidence, but deserved none the less! The vast majority of my tinkering is private and simply for my own amusement

cmbasnett commented 8 months ago

@CraftPig Please let me know if any of what's written here sorts out the issue you were having. If so, I will close the issue.

cmbasnett commented 7 months ago

Closing the issue, as there's been no response.