DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such

GNU General Public License v3.0

21 stars 21 forks source link

Rework UX on adding a speaker without a photo #186

Closed darkterreur closed 5 years ago

darkterreur commented 5 years ago

PR information

Q	A
Branch?	Develop
Bug fix?	yes
New feature?	no
Tests pass?	no
Related issue	#181

Description

Update fields for to be required

tdutrion commented 5 years ago

Please update the description to remove the default description @darkterreur

tdutrion commented 5 years ago

Not sure what the aim of this PR is, one change is making the field mandatory, the other one is just checking whether a value exists.

If mandatory, then the empty should not be there, as we should have validators before preventing to execute this code. If not required, then the empty should be there.

I do believe it should not be required, as many people do not have a picture available just sitting there.

alcalyn commented 5 years ago

Reintegrated in https://github.com/DarkmiraTour/community-event-manager/pull/197