search

DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such
GNU General Public License v3.0
21 stars 21 forks source link

Remove npm related files in favour of yarn #193

Closed tdutrion closed 5 years ago

tdutrion commented 5 years ago

Description

Both yarn and npm may be used in order to compute and install node dependencies. Yarn is our selected package manager, as demonstrated in the docker-compose.yml file where it's used. Npm should therefore not be used, and the lock file for npm should not be provided.

Scenarios

While running the installation after cloning, the yarn install script returns the following warning:

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

The package-lock.json should therefore be removed altogether.

alcalyn commented 5 years ago

Oh in fact it has be done with PR https://github.com/DarkmiraTour/community-event-manager/pull/198

All npm related files or make commands is removed.