DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such

GNU General Public License v3.0

21 stars 21 forks source link

Monolog is only required in dev dependencies #212

Closed tdutrion closed 5 years ago

tdutrion commented 5 years ago

PR information

Q	A
Branch?	Develop
Bug fix?	no
New feature?	no
Tests pass?	yes
Related issue	#212

Description

Monolog is only required in dev yet, so it can't work in prod

cvilleger commented 5 years ago

If there is no Monolog in prod, what about this prod config file, do you let him go ? And what about logging in production ? : https://github.com/DarkmiraTour/community-event-manager/blob/develop/config/packages/prod/monolog.yaml

hermann8u commented 5 years ago

This is something really common in Symfony 4 applications because the monolog-bundle is in the symfony/debug-pack.

To fix this and still have monolog in production I follow this step:

composer unpack debug : It's a symfony flex command to remove the debug-pack in composer.json and add the pack dependencies explicitly.
Move the symfony/monolog-bundle from the require-dev section in the require section.

Hope it will help !

tdutrion commented 5 years ago

I would still be in favour of removing it from production since Symfony\Component\HttpKernel\Log\Logger can do the job for us there. What do you think @cvilleger and @hermann8u considering the class above is available for sure in production?