DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such
GNU General Public License v3.0
21 stars 22 forks source link

Fix `minio/minio` and `minio/mc` images versions #214

Closed Rantignac closed 4 years ago

Rantignac commented 4 years ago

Current Behavior

During build and initialize the project. we encounter the following error : image

How to reproduce scenario

Clone the application and make install in /community-event-manager

Possible solutions

Fix this bug by changing the minio/minio version (to RELEASE.2019-09-26T19-42-35Z) in docker-compose.yaml and the minio/mc version (to RELEASE.2019-09-24T01-36-20Z) in Makefile

tdutrion commented 4 years ago

From the master branch, clean clone, no problem on my side (can't reproduce then).

Here's my docker logs community-event-manager_storage_1 afterward:

Endpoint:  http://172.21.0.3:9000  http://127.0.0.1:9000

Browser Access:
   http://172.21.0.3:9000  http://127.0.0.1:9000

Object API (Amazon S3 compatible):
   Go:         https://docs.min.io/docs/golang-client-quickstart-guide
   Java:       https://docs.min.io/docs/java-client-quickstart-guide
   Python:     https://docs.min.io/docs/python-client-quickstart-guide
   JavaScript: https://docs.min.io/docs/javascript-client-quickstart-guide
   .NET:       https://docs.min.io/docs/dotnet-client-quickstart-guide

So everything seems alright on my side, on the latest stable osX with the latest docker-for-mac edge (running with kubernetes but that should not matter).

Could you describe your setup more extensively?

tdutrion commented 4 years ago

Ok second time around (same clone as the time before, haven't reset the folders created).

I just did a docker-compose pull to fetch the latest version of every image we have.

make install succeed but contains the following output:

docker run --network container:`docker-compose ps -q storage` \
               --entrypoint="" \
               -v `pwd`:/app \
               -w /app \
               minio/mc \
               /bin/sh -c "chmod +x ./docker/minio/create-bucket.sh && ./docker/minio/create-bucket.sh"
Added `minio` successfully.
Removing `minio/events/photos/25dd65ac-d0e4-49db-a65d-85b3baa3e4fe.jpeg`.
Removing `minio/events/photos/282eee32-36ff-49f9-9882-1b2c96a0110a.jpeg`.
Removing `minio/events/photos/2db8c05d-07cc-4e47-aac1-1f12f96a3d48.jpeg`.
Removing `minio/events/photos/34039704-354c-4fa6-97c4-e85da5e36ffa.jpeg`.
Removing `minio/events/photos/368f10af-eb83-4329-b7f3-8b20365a05c7.jpeg`.
Removing `minio/events/photos/3b8b73d4-ff9d-43b5-b5dc-171ef6c668f5.jpeg`.
Removing `minio/events/photos/3d9fdbdf-cbd6-4633-9cbc-313e8917e89d.jpeg`.
Removing `minio/events/photos/6cb9ce30-b3be-49e9-954d-c6b788c951a1.jpeg`.
Removing `minio/events/photos/7bf37557-ea17-4110-b8fc-ae33d0272579.jpeg`.
Removing `minio/events/photos/7e2c7078-e8e2-4748-8e2b-252046cc8316.jpeg`.
Removing `minio/events/photos/c9e54bb8-c26b-4197-a4b1-bd0058504d8f.jpeg`.
Removing `minio/events/photos/cefebf3c-480f-454c-a502-1688d1fe2c58.jpeg`.
Removing `minio/events/photos/db3750f5-08d7-4432-9a70-0354c50ce2f2.jpeg`.
Removing `minio/events/photos/e7f852a4-f441-439d-84ea-73d844f27292.jpeg`.
Removing `minio/events/photos/`.
mc: <ERROR> Unable to make bucket `minio/events`. Your previous request to create the named bucket succeeded and you already own it.
Access permission for `minio/events` is set to `download`

The Removing lines were to be expected as the image from the previous install are overwritten. Then the mc error is fine, just state that everything already exist and is fine.

Everything works perfectly once again then.

Rantignac commented 4 years ago

After a docker pull minio/minio and docker pull minio/mc it works :wink:

surodri commented 4 years ago

Hi, I looked at your docker-compose.yaml and it looks like it is using the latest version of minio.

 storage:
        image: minio/minio:latest
        ports:
            - '9001:9000'

Is the enhancement still to change it to the specific version RELEASE.2019-09-24T01-36-20Z ?

tdutrion commented 4 years ago

Yes it is @surod22. Thanks for your interest in this issue.

We would like to set both that image and the image minio/mc in the Makefile, because they sometimes change the way it should be configure, so using a well defined version will avoid setup problems.

If you were to do it, please update both docker-compose.yml and Makefile and test a local installation from scratch (doing a docker rmi of the images beforehand).

Thanks very much again for your interest!