refactor the address Entity

DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such

GNU General Public License v3.0

21 stars 22 forks source link

refactor the address Entity #224

Open phillipsb22 opened 4 years ago

phillipsb22 commented 4 years ago

Fix #217: Refactor the Address Entity.

Is this what you are looking for. If you would like to advise changes please do so. I am also open to doing the other entities

tdutrion commented 4 years ago

Thanks for the work you did. The aim is indeed to refactor the entity so that's it is always in a valid state and does not leak the implementation.

I would assume changing that must also have an impact (non trivial) on object hydration with Symfony Form as well as validation.

phillipsb22 commented 4 years ago

What are your thoughts with updating addresses? Are you wanting to create a new address each time? These updates will no longer work (src/Dto/AddressRequest.php:48).