DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such

GNU General Public License v3.0

21 stars 21 forks source link

Feature oriented architecture for space domain #246

Open darkterreur opened 4 years ago

darkterreur commented 4 years ago

PR information

Q	A
Branch?	feature_oriented_architecture_for_space_domain
Bug fix?	no
New feature?	yes
Tests pass?	yes
Related issue	Fixes #244

Description

Migrate Space and SpaceType on the new architecture

kuraobi commented 4 years ago

I see that you chose to group Space and SpaceType creation in App\Space\Create namespace (same with Update etc.). I don't think that Space and SpaceType creation are actually related: maybe we should manage SpaceType as a sub-namespace, i.e. App\Space\SpaceType\Create\CreateSpaceTypeAction instead of App\Space\Create\CreateSpaceTypeAction (same with Update etc.).

cgrandval commented 4 years ago

I see that you chose to group Space and SpaceType creation in App\Space\Create namespace (same with Update etc.). I don't think that Space and SpaceType creation are actually related: maybe we should manage SpaceType as a sub-namespace, i.e. App\Space\SpaceType\Create\CreateSpaceTypeAction instead of App\Space\Create\CreateSpaceTypeAction (same with Update etc.).

I agree with you @kuraobi. @darkterreur can you please do changes as @kuraobi said.