search

DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such
GNU General Public License v3.0
21 stars 21 forks source link

Update CS fixer #248

Open kuraobi opened 5 years ago

kuraobi commented 5 years ago

Current Behavior

CS fixer is locked to v2.14 in composer.lock, but the CI uses the latest v2.16 which has updated rules for @Symfony. These now include for example no_superfluous_phpdoc_tags and ordered_imports (https://github.com/keradus/PHP-CS-Fixer/commit/a0df28285e61c9fb52cca313ad64f2329a71a6ae).

How to reproduce scenario

Submit any PR that is not compliant with the latest Symfony CS ruleset.

Expected behavior

CI and dev should run the same CS fixer version to allow for fixing problems automatically before pushing code.

Possible solutions

composer update friendsofphp/php-cs-fixer && git add composer.lock && git commit -m "updated cs fixer" && git push