add symfony test pack and start tu

DarkmiraTour / community-event-manager

Web application with a collection of tools helping people organising community events such as multi-days conference with reminders, CRM and such

GNU General Public License v3.0

21 stars 21 forks source link

add symfony test pack and start tu #92

Closed Diwoka closed 5 years ago

tdutrion commented 5 years ago

Hi @Diwoka! Thanks for this PR.

Just a few things:

[ ] Add a description
[ ] Add a related issue (things should be discussed in issues prior implementation to avoid spending time on fuzzy issues)
[ ] The keyword and in the PR name means the PR is not atomic enough, a PR should be feature specific
[x] Codacy issues have not been fixed (and they are all fixable easily)

kevinjhappy commented 5 years ago

Please rebase with develop and squash your commit @Diwoka and fill the requirement from Thomas about description and adding an issue to relate to :) This way we will be able to merge your PR if everything is good :)

cgrandval commented 5 years ago

I'll close this issue because it was opened for too long. If you think you can reopened it, please rebase with develop, squash your commits, add a description, and create a related issue. As it's a long time PR, have a look before if the modifications you wanted to do, were not done in another issues.