Darkpeninsula / Darkcore

DarkCore Project is a no-profit Open Source community. **We're looking for contributors** to keep this project up-to-date !!
http://project.darkpeninsula.eu/
GNU Affero General Public License v3.0
39 stars 25 forks source link

Min / Max loot dropped by a creature bugged #59

Closed Walkum closed 12 years ago

Walkum commented 12 years ago

Hi, I will explain better as I can.

One heroic boss (for example), have 4 creature_loot_entries, of 20% each one. Ok, when you kill these boss, ALWAYS must drop one item min, and one item max, ignoring the percentage. About one raid boss (for example), 4 creature_loot_entires of 10% each one (for example), when you kill, the boss must drop minimum 4 items, and maximum 4. If these creature is not raid boss, not have minimum drop and you need have lucky of these 10% of drop for the creature drop the item for you.

I don't know if I explained good...

This is a high priority bug, because for example, one heroic boss can drop 8 items, or nothing, and one heroic boss must drop 1 item minimum and 2 items max.

This have a easy solution?

Thanks in advance.

Thema89 commented 12 years ago

I'm not sure I've understood, but anyway, if I'm correctly reading you, your use of creature_loot_template table is unappropriate: Min/Max loot just check item's STACKS that could be dropped.

There's a column called "groupid" that does that work for you instead... For example, if you are going to put on some loot entries for a boss:

1) You should put all items from which he randomly pick ONLY ONE OF THEM and give that entry groupid value = 1 (or 2, 3, 4... just have to be the same number for every entry)

2) There's no need to explicit loot percentage if there are all equal-chanced, put ChanceOrQuestChance = 0 to make them all equal-chanced loot.

With this method, your npc will always loot at least one of that items, and if all are equal-chanced ( ChanceOrQuestChance = 0) the picking will be made randomly.

You could see one loot entry already populated, from WOTLK or TBC (don't think SkyFire's ones are correct... /respect for their work obviously, but I'm not sure that their Dev who made this loot entries were expert...)

I'm going to publish a cleanup example soon, by the way ;)

Thema89 commented 12 years ago

( see TrinityCore Wiki for further info: http://www.trinitycore.info/Loot_template_tc2#groupid )

Walkum commented 12 years ago

yes, now works, very sorry for the wrong issue.

I reported it because all the values is from TDB, not from Skyfire... and I though that TDB had good values but no, all values are bad (for example the mangos database YTDB have all correct values)... its a problem of TDB, this problem is on all bosses of the game.

Sorry again for this, and very very very thanks for tell me the solution ^^

Thema89 commented 12 years ago

Ok, I'm glad to see you've solved... I'll close this issue :)

That's a very bad news you're telling me anyway, if that's a TDB epic-fail, there's a lot of work to do to cleanup all that fails =/

Walkum commented 12 years ago

I will make a SQL fixing all bosses that I find :), thanks for all Thema ^^

Thema89 commented 12 years ago

You're welcome :D