Darkrp-community / OpenKeep

Open source repository for StoneKeep
GNU Affero General Public License v3.0
8 stars 52 forks source link

[Suggestion]: fix treasuries passive income #106

Open Wateronix opened 1 month ago

Wateronix commented 1 month ago

Category

Balance

What is the suggestion?

The Issue: Currently you can put any item into the vault and have it generate interest at quite ridiculus rates, without code diving i think it is somewhere arround 20-ish percent. As the treasury is also filled with a lot of money roundstart, you can have infinite money, very quickly.

Possible Solutions:

Why is this suggestion good?

Free money, without having to do anything, is not really interesting.

Staff consulted

No response

Wesreidau commented 1 month ago

I would agree it can cap obscenely high, but it also provides the king the sort of passive tax income he needs to pay guards and so forth. Also the vault is a poorly-patrolled target for thief roleplay, and if there is no wealth in in it or reason to fill it with wealth, it will be wasted roleplay potential.

ThePainkiller commented 1 week ago

Economy and vault rebalance currently being worked on

InsightfulParasite commented 6 days ago

https://github.com/Darkrp-community/OpenKeep/pull/300 Some notes that may help in understanding the issue. The treasury takes 25% of the sellprice of items. So if you have 4 100 sellprice items you will get (25*4)/queens tax which is randomized on intilization. Initialization queens tax ranges from 9% to 30% meaning at best you will get 91 mammon from the 4 100 items but at worst you get 70 mammon.

The queens tax serves no function other than limitation. This isnt nessesarily a bad thing its just that the money taken by the "queen" stops existing in the round.

InsightfulParasite commented 6 days ago

It is a strange system since it is a investment mechanic. If the town cannot survive on its own commerce by selling copious amounts of apples and buying several pounds of iron you can invest and become disconnected from the town.

Wesreidau commented 5 days ago

All right, after thinking about this with some Merchant rounds as opposed to Hand rounds I've got some thoughts.

  1. The current system accepts coins at face value for purposes of being interest-bearing treasure.
  2. There is a very simple loop of turning treasury to coins and throwing coins in the vault to get more principle for the interest.
  3. The loop to turn money to treasure is far more complicated with imports, exports, player interaction, haggling, conversation... so nobody does it.

If we remove 1 and 2 from the formula, that is, check if an object is a coin and if so, don't consider it a vault treasure, suddenly the steward is engaged in 3: buying resources and having others turn it into treasure or other valuables, then moving these large bulky objects into the keep.

That fixes the vault being a money printer.

I'd like to tackle this, actually.

Technobug14 commented 5 days ago

That's great and all except play Steward and try to get players to provide treasures or other valuables. You'll bawl your eyes out and the King will be pissed that the Kingdom is broke. Maybe you'll have more success if you play a female Steward who'll spread her legs for gold ingots and gemeralds. Even if you manage to find someone willing to sell you these things, good luck buying them with no mammons in the treasury from paying the guards and such.