Darkrp-community / OpenKeep

Open source repository for StoneKeep
GNU Affero General Public License v3.0
17 stars 93 forks source link

[Bug]: Anonymize Broken in Two Ways #702

Open NormalAnomaly opened 2 months ago

NormalAnomaly commented 2 months ago

Checks

Map

RogueTown

Describe the issue

Basically as long as Stonekeep has been Stonekeep, the anonymize button has been broken. People can no longer toggle their anonymize status, clicking the button does nothing.

Also, even people who are set to be anonymized will have their ckey revealed if they join as normal town roles after roundstart (not drifters, drifters are still hidden correctly). If you ready up as a normal town role before roundstart, you will be hidden correctly, but if you die then latejoin that second character will reveal your ckey. Same for any other latejoin town role.

How to reproduce

Problem 1: Click Anonymize button, observe nothing happening.

Problem 2: With anonymize on, latejoin normally as a class like weaponsmith or soilson or what have you (not as a drifter, and I never tested with towner). Observe your ckey revealed in the end round show players list.

Round ID

No response

Staff ckey

No response

NormalAnomaly commented 3 weeks ago

Probably worse now, since the drifter que is gone. Latejoin towners and adventurers are also not anonymized. So everyone that latejoins has their ckey shown in spite of having anonymize set on by default.