search

Darkrp-community / OpenKeep

Open source repository for StoneKeep
GNU Affero General Public License v3.0
16 stars 85 forks source link

[Bug]: Weapon quality does not properly affect armor penetration #957

Open anything86 opened 21 hours ago

anything86 commented 21 hours ago

Checks

Map

Dun Manor

Describe the issue

Code oversight makes it so that the "armor_penetration" being multiplied by quality at weapon generation through smithing is the base 5 weapon_penetration assigned to every weapon, ignoring the bulk of it which comes from intents through the spec_attacked_by proc.

How to reproduce

Find out IC.

Round ID

No response

Staff ckey

No response

NPC1314 commented 15 hours ago

Having mulitpliers based on quality is somewhat questionable in itself, could just be a straight up minor force boost or for armor boost to integrity. When it affects everything balance becomes such a pain, how good is weapon x vs armor y?

when everything is malleable that becomes a chore to keep track of.

anything86 commented 7 hours ago

Having mulitpliers based on quality is somewhat questionable in itself, could just be a straight up minor force boost or for armor boost to integrity. When it affects everything balance becomes such a pain, how good is weapon x vs armor y?

when everything is malleable that becomes a chore to keep track of.

I've no mind on the matter, but because armor quality multiplies protection values correctly right now, this compounds on the issue of armor being too powerful.