Can we get the docker updated to latets version ?

Darkside138 / DiscordSoundboard

Java Soundboard for Discord

Apache License 2.0

137 stars 55 forks source link

Can we get the docker updated to latets version ? #160

Closed L4wlz closed 2 years ago

L4wlz commented 3 years ago

https://hub.docker.com/r/obenned/discordsoundbot is still version 3.0.4 ? can't this somehow be alligned so it always will have the new version ? :)

cnschu commented 3 years ago

have you talked to the owner of this docker repository?

L4wlz commented 3 years ago

It just looks like the support was pointed over here. I can try tag him. @OBenned - Can you please update the docker on the https://hub.docker.com/r/obenned/discordsoundbot so it can get the newest version.. I tried to do a fresh install and i still get the old version 3.0.4 ?

Darkside138 commented 3 years ago

I'm no docker expert but the dockerfile seems to be pointed at the latest release.

RUN wget $(curl -sL https://api.github.com/repos/Darkside138/DiscordSoundboard/releases/latest | jq -r '.assets[].browser_download_url')

I would think a fresh install would get the latest version.

L4wlz commented 3 years ago

I have done a fresh install of the docker before posting here :) but the version is still 3.0.4 :( -

But i can give it a try again for sure

L4wlz commented 3 years ago

I just did a complete reinstall of the docker from the dockerhub. :)

So remove my container and all it contents.
Removed images and a clean up everything. But it still gives me Version 3.0.4 but should been version 3.0.5 ? Normally i can via portainer just edit current container and then check Always pull the image and then redeploy- works just fine with other dockers :) So it does not make any sense. :( I hope maybe @OBenned can assist ? =)

OBenned commented 3 years ago

When i try and down the ZIP file using the command the docker image uses i get the latest version, timestamp 5. january 2021

I havent tried the image yet, but i will give a shot

OBenned commented 3 years ago

I have found the issue.

The problem is, cause of my own mistake, when i build the image it pulls the latest version, and when the image was last build was in version 3.0.4. So the zip is not pulled during the startup of the container but when i build the image.

So there are two possible solutions.

The docker image has to rebuild with every new version.
The docker image needs to be redesigned so it can handle this instead of rebuild, i dont have the time for this solution atm.

I have rebuild and pushed the newest version to docker hub now.

@Darkside138 Tell me what solution you would prefer

L4wlz commented 3 years ago

@OBenned Thanks.. I have just rebuild it and now it is the latest version. But yeah solution 2 will be best :D but the time needs to be there..

OBenned commented 3 years ago

The 2 version is actually the worst because everytime you start the container you need to pull the latest release, unless we do some fancy check on releases. The good thing about how its done now, is that we "bake" the image with the latets release, so imo more safe doing it this way.

@Darkside138 we could setup a build chain with docker if you want

Darkside138 commented 2 years ago

@OBenned, I'm about to push a new release. I wouldn't mind setting up some kind of build chain. Let me know if you want to work together on it.

OBenned commented 2 years ago

@Darkside138 For sure, im up for that!