search

DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 551 forks source link

Instance of killer being null when it should not be, in onMobDeath #1561

Open Zenny89 opened 9 years ago

Zenny89 commented 9 years ago

I read issue #1538 and have repeated it numerous times on my SCH. Cast a helix on a worm, so that it takes 4-5 ticks to kill the worm. After the second to last tick the worm becomes unclaimed. On the last tick, the worm dies unclaimed, and I do not receive any experience points.

TeoTwawki commented 9 years ago

I would think the real issue here is that the mob came unclaimed before it should have.

teschnei commented 9 years ago

why should it not have? if you cast helix and then do nothing, why is it surprising that it eventually became unclaimed?

TeoTwawki commented 9 years ago

Because its still dott'ed and dotted mobs don't unclaimed normally? Is helix diff from other dots like that on retail? You tell me.

teschnei commented 9 years ago

it's not, but i don't think a dot keeps claim

TeoTwawki commented 9 years ago

It'll eventually declaim, but just poison is usually enough to hold something for quite a while before it happens. I just assumed he's reporting it because it happened faster than normal.

TeoTwawki commented 9 years ago

Otherwise...unclaimed mob, not supposed to grant you exp anyway, and killer is correct to be null/nil.

Zenny89 commented 9 years ago

Yes, it does seem to come unclaimed really fast. I haven't timed it, but 4-5 ticks of a helix doesn't seem like much time at all.

bendangelo commented 9 years ago

Does poison and other dots hold claim on retail? I don't remember.

TeoTwawki commented 9 years ago

I I don't know if its dot itself or just the enmity + a short grace period (unless you switch targets, then you lose it instantly thats another thing dsp doesn't have yet).

I could be wrong though. Best to get someone on retail to try a few diff duration dots while pinning and see if they always stay past the duration and past the enmity generated.