search

DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 549 forks source link

First tier cure/dia/haste have more hate than provoke #2197

Closed nasomi closed 9 years ago

nasomi commented 9 years ago

https://github.com/DarkstarProject/darkstar/commit/80d6c3746b906242f430359736c690b0512ccd08

Whm casts one cure and steals hate from tank after multiple vokes/weaponskills.

teschnei commented 9 years ago

Adding on to this: dia and haste are probably correct. Dia for sure. The difference is they generate CE while provoke does not. If the tank takes enough damage and doesn't deal enough to generate CE, this is expected. However, it's not out of the realm of possibility that the CE decay is wrong, or that cure is generating too much CE. It's also possible that these players are used to cures generating no CE (as that was the case always before a few days ago) and are not gearing/playing their tanks properly.

Deadwing888 commented 9 years ago

I'll update my server and take a look at the prints

Deadwing888 commented 9 years ago

Enmity appears genuinely broken at the moment. Cures give no hate, damage gives no hate, damaging spells give no hate, enfeeble spells give hate but it's reset to 0VE 1CE if you cast a spell.

Edit: was broken both before and after nas's pull request

teschnei commented 9 years ago

Have you updated since this issue was closed?

Deadwing888 commented 9 years ago

Yes, I've tried both yours and nas's enmity_container it seems broken for both

Deadwing888 commented 9 years ago

Looking at more prints, damage does generate some enmity, but it keeps getting reset to 0VE 1 CE

takhlaq commented 9 years ago

did you rebuild?

Deadwing888 commented 9 years ago

Yeah, I'm 95% sure I'm using the correct enmity_container and there appear to be these problems on Nasomi server as well

bendangelo commented 9 years ago

What's the easiest way to reproduce?

Deadwing888 commented 9 years ago

Casting spells seems to be resetting enmity in some fashion. Also cures produce no VE and 1 CE all the time.