search

DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 549 forks source link

Draw-in can still get players stuck in the ground #2511

Open Hozu opened 8 years ago

Hozu commented 8 years ago

I remember that there was a commit that added a valid navmesh location check, but it doesn't appear to be enough/isn't working properly because players can still get stuck in the ground. Also, while the thing where players get popped up a bit on draw-in was added, it doesn't seem to be enough? I don't know how high it bumps you on retail, but it was noticeable if people know about it. I can't see any vertical height gaining when drawn-in on DSP servers.

teschnei commented 8 years ago

well, there's kind of a huge problem with how this works: IIRC, moving mobs don't ever change their y position relative to the terrain they are moving over (the only way to do so would be to check the bounds of the navmesh, which is pretty new and probably doesn't do so). So the problem is that the y value of a mob can't ever really be trusted (especially since the client auto corrects it) - meaning that no matter what we try to offset the draw in position by, it could still be wrong also, the "height correction" is only 0.5, so you wouldn't notice it

Hozu commented 8 years ago

Ah, well that explains the whole problem. :/

bendangelo commented 8 years ago

It's possible to get the Y position from a point on the navmesh but there is still a chance it'll be in a non-walkable spot. I think a more generous height correction is our best bet.

teschnei commented 8 years ago

Best to get the y pos from the navmesh and then move it up a bit. No way we can do it without that

Warp-ass commented 8 years ago

i think setting it to extra height on its exact horizontal coords would be fine, the player just falls, which is kinda like getting 'knocked up' as you get drawn in. from what i recall it takes an excessive amount of height for falling to not work.

dr01d3r commented 8 years ago

Months ago, I tried doing a height offset with Tiamat draw-in; however, due to the terrain, either the offset was not enough or it caused the player to jump multiple times (multiple draw-ins, i believe).

TeoTwawki commented 8 years ago

Additional prob someone just pointed out to me: draw in should place those draw in directly in front of the target. Seems with some larger mobs you land either inside or worse, behind the mob. This is especially bad with stuff like Wymrs given drawn in because spike Fail. That's a not a typo 😃