DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 549 forks source link

DRG Attack, defense, job ability haste buffs when Wyvern is out? #3744

Open ghost opened 7 years ago

ghost commented 7 years ago

I have:

Client Version (type /ver in game) : version 30161227_1

Server Version (type @revision in game) : Unknown

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) : From BGWiki: https://www.bg-wiki.com/bg/Call_Wyvern

"While alive the Wyvern gives a variety of effects to the Dragoon.

20% Attack Bonus
20% Defense Bonus
10% Job Ability Haste

... Attack Bonus and Defense Bonus potency begins at 10% but increases by 2% each time the Wyvern's 'attributes increase' for a maximum of 20%, the Haste effect begins at 0% but likewise increases in increments of 2% until it reaches 10%. Source: http://forum.square-enix.com/ffxi/threads/43912-dev1229-Job-Adjustments"

I could be really wrong about this, but it seems simple to do like addMod(MOD_ATTP) to player after call wyvern and delete them after dismiss/wyvern's death? Oh.. but the increments...hmm

teschnei commented 7 years ago

It is as you think, fairly simple - the flat bonus would be added on summon and deleted on dismissal, and the increments would be added when the wyvern levels up, and then deleted when dismissed (of course, keeping track of the number of times it levelled up)

On Wed, Feb 22, 2017 at 10:55 PM, soupcans notifications@github.com wrote:

I have:

Client Version (type /ver in game) : version 30161227_1

Server Version (type @revision in game) : Unknown

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) : From BGWiki: https://www.bg-wiki.com/bg/Call_Wyvern

"While alive the Wyvern gives a variety of effects to the Dragoon.

20% Attack Bonus 20% Defense Bonus 10% Job Ability Haste

... Attack Bonus and Defense Bonus potency begins at 10% but increases by 2% each time the Wyvern's 'attributes increase' for a maximum of 20%, the Haste effect begins at 0% but likewise increases in increments of 2% until it reaches 10%. Source: http://forum.square-enix.com/ffxi/threads/43912-dev1229- Job-Adjustments"

I could be really wrong about this, but it seems simple to do like addMod(MOD_ATTP) to player after call wyvern and delete them after dismiss/wyvern's death? Oh.. but the increments...hmm

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DarkstarProject/darkstar/issues/3744, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGI_24SvP_8yI82YC5P6wPwPXi3mzAyks5rfR9vgaJpZM4MJk2Y .

Hozu commented 7 years ago

I believe those buffs are being applied to the wyvern itself, currently. I thought that's how it was supposed to be? Didn't think the buffs were to the player itself...

teschnei commented 7 years ago

2014 change

On Feb 23, 2017 9:25 AM, "Hozu" notifications@github.com wrote:

I believe those buffs are being applied to the wyvern itself, currently. I thought that's how it was supposed to be? Didn't think the buffs were to the player itself...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DarkstarProject/darkstar/issues/3744#issuecomment-282042385, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGI_xmVgGq8EpGogf17vrvWE4WDa1A2ks5rfbLigaJpZM4MJk2Y .