Doom removal chance is incorrect

[Hozu]

I have:

• [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
• [x] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) : current

Server Version (type @revision in game) : current

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) :

https://www.bg-wiki.com/bg/Cursna

• [ ] Removal rate is affected by healing skill - 10% at 0, 30% at 600, and 43% at 1000. No known cap.

This post adds another data point - 26% at 500. https://www.bluegartr.com/threads/112776-Dev-Tracker-Findings-Posts-(NO-DISCUSSION)?p=6880062&viewfull=1#post6880062

• [x] Holy water is 33% - DSP has it at 25%. https://www.bluegartr.com/threads/112776-Dev-Tracker-Findings-Posts-(NO-DISCUSSION)/page38 (note: that post erroneously says Cursna removes at 30% chance at 500 skill).

• [x] Hallowed Water is the same rate as Holy water (33%) - DSP has it at 50%. https://www.bluegartr.com/threads/112776-Dev-Tracker-Findings-Posts-(NO-DISCUSSION)?p=6519212&viewfull=1#post6519212

• [x] Modifers that affect the Doom removal rate of Cursna increases it by a percent of the current removal rate. For example, +10 modifier at 0 skill would change the rate from 10% to 11%, while at 600 skill it would be from 30% to 33%. Note that there is a cap to removal, at 99%. https://www.bluegartr.com/threads/112776-Dev-Tracker-Findings-Posts-(NO-DISCUSSION)?p=6635343&viewfull=1#post6635343

Again, I can't test so I can't be making pull requests here.

[R3P0FFXI]

@Hozu This may be a duplicate of a previous issue, Doom actually has not been working on DSP for a while due to a tick issue

https://github.com/DarkstarProject/darkstar/issues/3599

[Hozu]

Nah that's a separate issue. The scripts involving removal of Doom have been wrong since the beginning.

[TeoTwawki]

@R3P0FFXI he just posted the actual numbers of the status in trunk vs what the devs have actually stated they are in retail. Nothing to do with the fact doom is wearing off before killing you when not removed.

And man that is lame, no reason to make hollowed water if not using it as a synth mat in something else then..

[TeoTwawki]

https://github.com/DarkstarProject/darkstar/commit/f8bbb6d7ce5e1cb38b93f67ffe6b22db0fb6c3e5 I took care of the 2 items percent chance, that just leaves the spell left

edit: added the missing modifiers for gear too https://git.io/vSxeo