DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 549 forks source link

Gravity does not seem to do much, if anything, since pull 5340 #5799

Closed Enedin9000 closed 5 years ago

Enedin9000 commented 5 years ago

Ever since pull 5340 (https://github.com/DarkstarProject/darkstar/pull/5340), Gravity does next to nothing. I just tried again as a fully decked out RDM75 on a DC crab in Boyahda and either it does nothing, or very little. Video here: http://enedin.be/Gravity_test.mp4

Client Version (type /ver in game) : 30190305_0

Source Branch (master/stable) : master/stable

Supernova server

TeoTwawki commented 5 years ago

Your server may need to update to fix a broken calculatePotency() line.

https://github.com/DarkstarProject/darkstar/commit/9fa4b42cee43ad33a1acfae9c9e4aab21be83e79#diff-17797eb281d50afd474603e21a29ee58R17

zynjec commented 5 years ago

Not an issue with master, so nothing we can do.

Contact Supernova.

Enedin9000 commented 5 years ago

thanks!

wrenffxi commented 5 years ago

(I'm on Supernova too)

This isn't an issue with old code (we're on latest DSP). It's changed in DSP too. It's a result of commit #5427, which reduced weight effect from Gravity spell from -50% movement to -26% movement, and Gravity II from -60% to -32%.

ffxiclopedia says Gravity is -50%. bgwiki says it's -26%. The -26% value seems like it comes from test by casting on players in Ballista in 2016.

It's harder to see a noticeable movement difference at -26%, and much easier at -50%. When I played retail, you could definitely see a difference when you cast Gravity, which makes me believe the -50% value is more likely. I haven't played retail in many years, so it's possible that retail Gravity's weight was nerfed at some point.

TeoTwawki commented 5 years ago

Also possible that the effects are diff between hitting a player and hitting a monster, or that it was 26% of a diff expression of movement speed.

Like 0-100 vs 0-255

base movement speed on the server might matter as well. whatchu guys got? (theres a setting for mobs as well as player - using stock?)

wrenffxi commented 5 years ago

Our base movement speed is +20% for players and mobs both, but I don't think it's any difference between DSP and Supernova that's the issue. I've tested on both. The code works in both cases. It's just the difference between the -50% it used to be and the -26% it is now. -50% is easy to see. -26% is less so, especially over short run distances. I believe in OP's video, there is a -26% movement, it's just hard to tell. I remember Gravity being more obvious, but these are very old memories.

TeoTwawki commented 5 years ago

honestly 26% in either direction should be pretty obvious, unless maaaaybe we're applying flat non % increases after it instead of before (I have not checked).

Snugglesffxi commented 5 years ago

our mobs set to +20% so i guess that would make our grav only -6%, guess that's why we can't see as it clearly.

nvm this is a dsp issue not sn specific.

TeoTwawki commented 5 years ago

maybe, maybe not. could still be something else. at work right now or I'd test the theory.

wrenffxi commented 5 years ago

It's not +20% - 26% = 6%.

Gravity slows a thing by 26% of whatever its base speed is. Our mob's base speed is higher than DSP. But it's a 26% cut either way.

TeoTwawki commented 5 years ago

The 20 isn't even a percent. its 20/255 added to the base of 40. I was questioning when that 20 gets added by DSP (again, let me point out this was conjecture without looking)

ignore everything I've suggested, somethin else going on entirely, see below

TeoTwawki commented 5 years ago

sooo I'm seeing mob speed being off even without grav involved...catching up to me while my movement is enhanced and theirs isn't. just a regular ol statue in sky, not a raptor.

Enedin9000 commented 5 years ago

@wrenffxi thanks for getting involved

wrenffxi commented 5 years ago

Yup, I did a bunch of testing last night, and agree with Teo. The root issue isn't gravity -- although its power was lowered from 50 to 26, the 26 value's probably right -- but instead, it's that the mob moves so much faster than the player, that when it follows you it's essentially slowing down / capping its speed to the player.

So when it takes a 26% movement hit, you don't notice, because it's still capping or nearly capping its speed. It looks like the mob lags behind the player only because of the time it takes the client to be updated about mob's position.

So this issue should be reopened as something like what Teo said above: "mobs move faster than players with identical speed, and even players with enhanced mod::MOVE."