X2 Guild point KI bought/Missing KI when bought

[AppleCrumble1]

I have:

• [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
• [] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version 31090328_2

Source Branch (master/stable) : master

Additional Information

I had 20k Guild points for smithing guild, I wanted to buy Chainwork and Sheeting KI's both 10k guild points each. I bought Sheeting KI and spenk 10k guild points and then Chainwork vanished from the KI list but Sheeting remained, Thought maybe it was a text id bug so tried to buy the second Sheeting hoping it would give Chainwork. It took the remaining 10k guild points and gave me Sheeting again. Checked my perm KI list and only showed sheeting once. Was rectified by GM to give Chainwork in game

[AppleCrumble1]

We run Master Source Branch so Teo just informed me.

[ibm2431]

Saving people some time: https://github.com/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/globals/keyitems.lua#L1982-L1983 (These IDs checked out when I used !addkeyitem 1994 and !addkeyitem 1995)

https://github.com/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/zones/Metalworks/npcs/Lorena.lua#L22-L31

https://github.com/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/zones/Northern_San_dOria/npcs/Macuillie.lua#L22-L31

Suspect the issue might be in here (maybe mismatched bit-shifting), but I don't know how this menu is supposed to work: https://github.com/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/globals/crafting.lua#L243-L253 While fixing this, should probably also add a safety check that the player doesn't already possess the KI before trying to give it to them.