search

DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 549 forks source link

Refactor bluemagic.lua to use dsp.damageType enum. #6399

Closed mrhappyasthma closed 4 years ago

mrhappyasthma commented 4 years ago

I also removed some unused constants from bluemagic.lua and cleaned up some style violations in BlueFinalAdjustments.

This is the first step before auditing all the blue mage spells to ensure they set the correct attackType and damageType.

This is pre-work for https://github.com/DarkstarProject/darkstar/issues/6225.

TeoTwawki commented 4 years ago

needs a rebase

mrhappyasthma commented 4 years ago

Rebased (well, conflicts resolved via merge commit from the GitHub UI. Didn't do a formal rebase since I'm working remotely.)